X-Git-Url: https://git.siccegge.de//index.cgi?p=frida%2Ffrida.git;a=blobdiff_plain;f=src%2Fdisassembler%2Fllvm%2FLLVMDisassembler.cxx;h=76b313de3bf996d0d355bc69e9b004c47d476efb;hp=25a4ecc25303087bee7c3b3e5265c5aa3bc91257;hb=9244195b13b1673757b4bc77d6306e7b2f21244a;hpb=370dc79ad6da88b8548d9ebd52601271bf279213

diff --git a/src/disassembler/llvm/LLVMDisassembler.cxx b/src/disassembler/llvm/LLVMDisassembler.cxx
index 25a4ecc..76b313d 100644
--- a/src/disassembler/llvm/LLVMDisassembler.cxx
+++ b/src/disassembler/llvm/LLVMDisassembler.cxx
@@ -126,6 +126,7 @@ void LLVMDisassembler::disassemble() {
     std::stack<LLVMBasicBlock*> remaining_blocks;
     SectionRef text_section = sections[".text"];
 
+	// Assume all function symbols actually start a real function
     for (auto x = symbols.begin(); x != symbols.end(); ++x) {
         uint64_t result;
         bool contains;
@@ -157,9 +158,6 @@ void LLVMDisassembler::disassemble() {
 
         LOG4CXX_DEBUG(logger, "Handling function " << current_function->getName());
 
-        // if ("_start" != current_function->getName())
-        //  continue;
-
         LLVMBasicBlock * block = new LLVMBasicBlock(current_function->getStartAddress(), this);
         remaining_blocks.push(block);
         blocks.insert(std::make_pair(block->getStartAddress(), block));
@@ -182,19 +180,6 @@ void LLVMDisassembler::disassemble() {
                 if(llvm::MCDisassembler::Success ==
                    DisAsm->getInstruction(inst, inst_size, ref, current_address, nulls(), nulls())) {
 
-                    uint8_t bytes[inst_size+2];
-                    ref.readBytes(current_address, inst_size, bytes);
-                    s << '\t';
-                    for(uint8_t* cur = bytes; cur < bytes + inst_size; ++cur) {
-                        s.write_hex(*cur);
-                        s << ' ';
-                    }
-                    s << '\t';
-
-                    IP->printInst(&inst, s, "");
-
-                    LOG4CXX_DEBUG(logger, std::hex << current_address + base_address << s.str());
-
                     uint64_t jmptarget;
                     if (MIA->evaluateBranch(inst, current_address, inst_size, jmptarget)) {
                         jmptarget += base_address;
@@ -208,18 +193,18 @@ void LLVMDisassembler::disassemble() {
                                     remaining_functions.push(fun);
                                 }
                             } else {
+								current_block->setNextBlock(0, jmptarget);
                                 if (blocks.find(jmptarget) == blocks.end()) {
                                     LLVMBasicBlock * block = new LLVMBasicBlock(jmptarget, this);
                                     blocks.insert(std::make_pair(block->getStartAddress(), block));
-                                    current_block->setNextBlock(0, block->getStartAddress());
                                     remaining_blocks.push(block);
                                 }
                                 if (MIA->isConditionalBranch(inst)) {
                                     jmptarget = base_address + current_address + inst_size;
+									current_block->setNextBlock(1, jmptarget);
                                     if (blocks.find(jmptarget) == blocks.end()) {
                                         LLVMBasicBlock * block = new LLVMBasicBlock(jmptarget, this);
                                         blocks.insert(std::make_pair(block->getStartAddress(), block));
-                                        current_block->setNextBlock(1, block->getStartAddress());
                                         remaining_blocks.push(block);
                                     }
                                 }
@@ -250,7 +235,7 @@ void LLVMDisassembler::disassemble() {
 		uint64_t base_address;
 		text_section.getAddress(base_address);
 		uint64_t current_address = current_block->getStartAddress() - base_address;
-		while(current_block->getEndAddress() - base_address != current_address) {
+		while(current_block->getEndAddress() - base_address > current_address) {
 			MCInst inst;
 			std::string buf;
 			llvm::raw_string_ostream s(buf);
@@ -260,14 +245,17 @@ void LLVMDisassembler::disassemble() {
 				auto other = blocks.find(current_address + inst_size + base_address);
 
 				if (other != blocks.end()) {
-					LOG4CXX_DEBUG(logger, "Shortening block starting at "
-								  << std::hex
-								  << current_block->getStartAddress()
-								  << " now ending at "
-								  << other->first);
-					current_block->setEndAddress(current_address + inst_size + base_address);
-					current_block->setNextBlock(0, other->first);
-					current_block->setNextBlock(1, 0);
+					uint64_t endaddress = current_address + inst_size + base_address;
+					if (endaddress != current_block->getEndAddress()) {
+						LOG4CXX_DEBUG(logger, "Shortening block starting at "
+									  << std::hex
+									  << current_block->getStartAddress()
+									  << " now ending at "
+									  << other->first);
+						current_block->setEndAddress(endaddress);
+						current_block->setNextBlock(0, other->first);
+						current_block->setNextBlock(1, 0);
+					}
 				}
 			} else {
 				inst_size = 1;
@@ -336,9 +324,17 @@ void LLVMDisassembler::printEachInstruction(uint64_t start, uint64_t end,
             uint8_t bytes[inst_size+2];
             ref.readBytes(current_address, inst_size, bytes);
 
-            IP->printInst(&inst, s, "");
+			uint64_t jmptarget;
+			if (MIA->evaluateBranch(inst, current_address, inst_size, jmptarget)) {
+				std::stringstream stream;
+				stream << std::hex << (base_address + jmptarget);
+				IP->printInst(&inst, s, stream.str());
+			} else
+				IP->printInst(&inst, s, "");
+
 			fun(bytes, inst_size, s.str());
         } else {
+			LOG4CXX_WARN(logger, "Invalid byte at" << std::hex << current_address + base_address);
 			fun(NULL, 0, "Invalid Byte");
 			inst_size = 1;
 		}