X-Git-Url: https://git.siccegge.de//index.cgi?p=frida%2Ffrida.git;a=blobdiff_plain;f=src%2Fdisassembler%2Fllvm%2FLLVMDisassembler.cxx;h=96418d86bbdded11fd4c530aef48f571c4300cd6;hp=3d969ef211975fde131ec83514beb561f220d5af;hb=3e7900dab2b4618d0c4fbe48d312cb74666af842;hpb=61fee0e142cbd73869f21e1a79e4038bb5c61335

diff --git a/src/disassembler/llvm/LLVMDisassembler.cxx b/src/disassembler/llvm/LLVMDisassembler.cxx
index 3d969ef..96418d8 100644
--- a/src/disassembler/llvm/LLVMDisassembler.cxx
+++ b/src/disassembler/llvm/LLVMDisassembler.cxx
@@ -58,7 +58,7 @@ LLVMDisassembler<ELFT>::LLVMDisassembler(const std::string& filename,
                                          InformationManager* manager,
                                          ObjectFile* file)
 	: Disassembler()
-	, logger(log4cxx::Logger::getLogger("LLVMDisassembler"))
+	, logger(log4cxx::Logger::getLogger("disassembler.LLVMDisassembler"))
 	, triple("unknown-unknown-unknown")
 	, manager(manager)
 {
@@ -199,7 +199,6 @@ Function* LLVMDisassembler<ELFT>::disassembleFunctionAt(uint64_t address, const
 			function->setName(name);
 		}
 		disassembleFunction(function);
-		manager->finishFunction(function);
 	}
 
 	return function;
@@ -207,6 +206,7 @@ Function* LLVMDisassembler<ELFT>::disassembleFunctionAt(uint64_t address, const
 
 template <typename ELFT>
 void LLVMDisassembler<ELFT>::disassembleFunction(Function* function) {
+	std::vector<uint64_t> called_functions;
 	std::stack<BasicBlock*> remaining_blocks;
 	/* TODO:
 	 * Do all blocks get added properly? We should take care to remove
@@ -225,6 +225,11 @@ void LLVMDisassembler<ELFT>::disassembleFunction(Function* function) {
 	new_blocks.insert(std::make_pair(block->getStartAddress(), block));
 	function->addBasicBlock(block);
 
+	uint64_t base_address, size;
+	text_section.getAddress(base_address);
+	text_section.getSize(size);
+	LOG4CXX_DEBUG(logger, "Text section at " << std::hex << base_address << " with size " << size);
+
 	while (remaining_blocks.size()) {
 		BasicBlock * current_block = remaining_blocks.top();
 		remaining_blocks.pop();
@@ -233,8 +238,6 @@ void LLVMDisassembler<ELFT>::disassembleFunction(Function* function) {
 		              << current_block->getStartAddress());
 
 		uint64_t inst_size;
-		uint64_t base_address;
-		text_section.getAddress(base_address);
 		uint64_t current_address = current_block->getStartAddress() - base_address;
 		while(true) {
 			MCInst inst;
@@ -250,7 +253,7 @@ void LLVMDisassembler<ELFT>::disassembleFunction(Function* function) {
 					if (!MIA->isIndirectBranch(inst)) {
 						if (MIA->isCall(inst)) {
 							if (NULL == manager->getFunction(jmptarget))
-								disassembleFunctionAt(jmptarget);
+								called_functions.push_back(jmptarget);
 						} else {
 							current_block->setNextBlock(0, jmptarget);
 							if (new_blocks.find(jmptarget) == new_blocks.end()) {
@@ -298,7 +301,9 @@ void LLVMDisassembler<ELFT>::disassembleFunction(Function* function) {
 	}
 	splitBlocks(function);
 	LOG4CXX_DEBUG(logger, "Finished function " << function->getName());
-	manager->signal_new_function(function);
+	manager->finishFunction(function);
+	for (uint64_t address : called_functions)
+		disassembleFunctionAt(address);
 }
 
 template <typename ELFT>
@@ -381,11 +386,16 @@ void LLVMDisassembler<ELFT>::splitBlocks(Function* function) {
 	text_section.getContents(bytes);
 	StringRefMemoryObject ref(bytes);
 
+	LOG4CXX_DEBUG(logger, "Splitting Blocks in Function " << function->getName());
 	// Split blocks where jumps are going inside the block
 	for (auto it = function->blocks().begin();
 	     it != function->blocks().end();
 	     ++it) {
 		BasicBlock * current_block = it->second;
+		if (current_block->getEndAddress() == 0) {
+			LOG4CXX_ERROR(logger, "UNFINISHED BLOCK " << std::hex << current_block->getStartAddress());
+			break;
+		}
 		uint64_t inst_size;
 		uint64_t base_address;
 		text_section.getAddress(base_address);