]> git.siccegge.de Git - frida/frida.git/commitdiff
Remove unused has* from InformationManager
authorChristoph Egger <christoph@christoph-egger.org>
Mon, 12 Oct 2015 06:16:39 +0000 (08:16 +0200)
committerChristoph Egger <christoph@christoph-egger.org>
Mon, 12 Oct 2015 06:16:39 +0000 (08:16 +0200)
The only used variant (hasFunction) is used by the disassembler to
determine whether to fall back to unsafe heuristics for finding the
entry. It is not really obvious why such a thing would ever come up for
one of the other types.

src/core/InformationManager.hxx

index f39f6e4335af3ef80c3cc5be58951293bc740e0b..30444acf068da98a39fb711c623c9976ac7a6d08 100644 (file)
@@ -56,7 +56,6 @@ public:
        std::map<uint64_t, Function*>::const_iterator endFunctions();
 
        BasicBlock* getBasicBlock(uint64_t address);
        std::map<uint64_t, Function*>::const_iterator endFunctions();
 
        BasicBlock* getBasicBlock(uint64_t address);
-       bool hasBasicBlocks() const {return blocks.size() != 0;}
        std::map<uint64_t, BasicBlock*>::const_iterator beginBasicBlocks();
        std::map<uint64_t, BasicBlock*>::const_iterator endBasicBlocks();
 
        std::map<uint64_t, BasicBlock*>::const_iterator beginBasicBlocks();
        std::map<uint64_t, BasicBlock*>::const_iterator endBasicBlocks();
 
@@ -64,7 +63,6 @@ public:
                std::multimap<uint64_t, Comment*>::const_iterator,
                std::multimap<uint64_t, Comment*>::const_iterator>
        getComments(uint64_t address);
                std::multimap<uint64_t, Comment*>::const_iterator,
                std::multimap<uint64_t, Comment*>::const_iterator>
        getComments(uint64_t address);
-       bool hasComments() const {return ! comments.empty();}
        std::multimap<uint64_t,Comment*>::const_iterator beginComments();
        std::multimap<uint64_t,Comment*>::const_iterator endComments();
 
        std::multimap<uint64_t,Comment*>::const_iterator beginComments();
        std::multimap<uint64_t,Comment*>::const_iterator endComments();