From 2c83a39c132aa0ea0ed0b771d160ada7691261f3 Mon Sep 17 00:00:00 2001 From: Christoph Egger Date: Fri, 28 Nov 2014 22:50:23 +0100 Subject: [PATCH] Change BasicBlockWidget and assume upperLeft is (0, 0) in local coordinates --- src/gui/widgets/BasicBlockWidget.cxx | 17 ++++++++--------- src/gui/widgets/BasicBlockWidget.hxx | 14 +++++++------- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/src/gui/widgets/BasicBlockWidget.cxx b/src/gui/widgets/BasicBlockWidget.cxx index 0164bdc..7b33fe0 100644 --- a/src/gui/widgets/BasicBlockWidget.cxx +++ b/src/gui/widgets/BasicBlockWidget.cxx @@ -1,11 +1,10 @@ #include "BasicBlockWidget.hxx" BasicBlockWidget::BasicBlockWidget(const QString& name, BasicBlock * block) - : x(-5), y(-20) - , dx(270), dy(45) - , name(name) - , block(block) { + : width(270), height(45) + , name(name), block(block) { next[0] = NULL; next[1] = NULL; + _widget.move(5, 20); _widget.setGridStyle(Qt::NoPen); _widget.setMinimumHeight(_widget.rowHeight(0) + 10); _widget.setMaximumHeight(20); @@ -17,8 +16,8 @@ BasicBlockWidget::BasicBlockWidget(const QString& name, BasicBlock * block) _widget.setColumnCount(3); _widget.verticalHeader()->hide(); _widget.horizontalHeader()->hide(); - dx = _widget.rowHeight(0) + 20; - if (dx < 270) dx = 270; + width = _widget.rowHeight(0) + 20; + if (width < 270) width = 270; } void BasicBlockWidget::addItem(uint8_t* bytes, size_t num_bytes, @@ -59,7 +58,7 @@ void BasicBlockWidget::addItem(uint8_t* bytes, size_t num_bytes, _widget.setMaximumHeight(_widget.rowHeight(0) * (_widget.rowCount()) + 2); - dy = _widget.rowHeight(0) * (_widget.rowCount()) + 25; - dx = column_width + 10; - if (dx < 270) dx = 270; + height = _widget.rowHeight(0) * (_widget.rowCount()) + 25; + width = column_width + 10; + if (width < 270) width = 270; } diff --git a/src/gui/widgets/BasicBlockWidget.hxx b/src/gui/widgets/BasicBlockWidget.hxx index 3c547b5..bc579a9 100644 --- a/src/gui/widgets/BasicBlockWidget.hxx +++ b/src/gui/widgets/BasicBlockWidget.hxx @@ -15,8 +15,6 @@ public: QRectF boundingRect() const { qreal penWidth = 1; - QRectF result(x - penWidth / 2, y - penWidth / 2, - dx + penWidth, dy + penWidth); if (next[0]) { @@ -32,6 +30,8 @@ public: result |= QRectF(QPointF(x + 2*dx/3, y+dy), mapFromScene(next[1]->getEntry())); + QRectF result(- penWidth / 2, - penWidth / 2, + width + penWidth, height + penWidth); return result; } void mouseMoveEvent(QGraphicsSceneMouseEvent *event) { @@ -43,15 +43,15 @@ public: } QPointF getEntry() const { - return mapToScene(QPointF(x + dx/2, y)); + return mapToScene(QPointF(width/2, 0)); } void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) { - painter->fillRect(x, y, dx, dy, QColor(0xcc, 0xcc, 0xff, 0xff)); + painter->fillRect(0, 0, width, height, QColor(0xcc, 0xcc, 0xff, 0xff)); painter->setPen(QColor(0x00, 0x00, 0xff, 0xff)); - painter->drawRect(x, y, dx, dy); - painter->drawText(0, -5, name); + painter->drawRect(0, 0, width, height); + painter->drawText(5, 15, name); if (_widget.rowCount() != 0) _widget.render(painter); @@ -83,7 +83,7 @@ public: } private: - int x, y, dx, dy; + uint32_t width, height; QTableWidget _widget; QString name; BasicBlock * block; -- 2.39.2