Support for Renaming Groups

[frida/frida.git] / src / gui / Mainwindow.cxx

diff --git a/src/gui/Mainwindow.cxx b/src/gui/Mainwindow.cxx
index fe48f8fd38cb4d0af385844466fc7e1921d5c22a..3b805d50a68db966cd4a3d7e922a562f2a9c8bc5 100644 (file)
--- a/src/gui/Mainwindow.cxx
+++ b/src/gui/Mainwindow.cxx
@@ -128,15 +128,38 @@ void Mainwindow::switchMainPlane(QTreeWidgetItem* to) {
 }
 
 void Mainwindow::showListContextMenu(const QPoint& point) {
+       QAction * act;
        QTreeWidgetItem * item = listWidget->itemAt(point);
        QMenu menu(this);
+
+       act = menu.addAction("Add Function");
+       connect(act, &QAction::triggered, this, &Mainwindow::requestNewFunction);
+
+       act = menu.addAction("Add Group");
+       connect(act, &QAction::triggered, this, &Mainwindow::requestNewGroup);
+
        if (item) {
-               QAction * act = menu.addAction("Rename Function");
-               connect(act, &QAction::triggered, [=]() {this->renameFunction(objects_list[item]->getFunction());});
-       } else {
-               QAction * act = menu.addAction("AddFunction");
-               connect(act, SIGNAL(triggered()), this, SLOT(requestNewFunction()));
+               if (objects_list.find(item) != objects_list.end()) {
+                       act = menu.addAction("Rename Function");
+                       connect(act, &QAction::triggered, [=]() {this->renameFunction(objects_list[item]->getFunction());});
+               } else {
+                       act = menu.addAction("Rename Group");
+                       connect(act, &QAction::triggered, [=]() {renameGroup(item);});
+               }
+
+
+               QMenu* submenu = menu.addMenu("Move to group");
+
+               for (QTreeWidgetItem* groupitem : group_list) {
+                       act = submenu->addAction(groupitem->text(0));
+                       connect(act, &QAction::triggered,
+                               [=] () {
+                                       listWidget->invisibleRootItem()->removeChild(item);
+                                       groupitem->addChild(item);
+                               });
+               }
        }
+
        menu.exec(listWidget->mapToGlobal(point));
 }
 
@@ -150,6 +173,18 @@ void Mainwindow::requestNewFunction() {
        }
 }
 
+void Mainwindow::requestNewGroup() {
+       SimpleStringDialog dialog("New Group");
+       int result = dialog.exec();
+       if (QDialog::Accepted == result) {
+               QTreeWidgetItem * external = new QTreeWidgetItem(listWidget, QStringList(dialog.result()));
+               external->setChildIndicatorPolicy(QTreeWidgetItem::ShowIndicator);
+               group_list.push_back(external);
+       } else {
+               LOG4CXX_DEBUG(logger, "requestNewGroup aborted");
+       }
+}
+
 void Mainwindow::requestNewFunctionByAddress(uint64_t address) {
        LOG4CXX_DEBUG(logger, "requesting Function at " << std::hex << address);
        manager->getDisassembler()->disassembleFunctionAt(address);
@@ -169,6 +204,18 @@ void Mainwindow::renameFunction(Function* function) {
        }
 }
 
+void Mainwindow::renameGroup(QTreeWidgetItem* item) {
+       SimpleStringDialog dialog("New name");
+       int result = dialog.exec();
+       if (QDialog::Accepted == result) {
+               LOG4CXX_DEBUG(logger, "renaming group " << item->text(0).toStdString()
+                             << " to " << dialog.result().toStdString());
+               item->setText(0, dialog.result());
+       } else {
+               LOG4CXX_DEBUG(logger, "renameFunction aborted");
+       }
+}
+
 void Mainwindow::addFunction(Function* fun) {
        if (functions.find(fun->getStartAddress()) != functions.end())
                return;